ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre Smits (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10407) create a docker image from the ofbiz system
Date Sun, 08 Mar 2020 10:00:01 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054356#comment-17054356
] 

Pierre Smits commented on OFBIZ-10407:
--------------------------------------

Thank you, [~mbrohl], for your feedback.


 * Re "we should use the Adopt Open JDK as listed in the requirements"
The readme.adoc in the repository on Github states
??The only requirement to run OFBiz is to have the Java Development Kit (JDK) version 8 installed
on your system??
and provides a link to an advised download location. However, many Linux distros (including
Ubuntu) provide OpenJDK binaries ready to use. So there is no need to do it differently;
* Re "xplicit Java installation can be removed by directly selecting the right Adopt Open
JDK Docker image"
The Adopt Open JDK Docker image puts the OpenJDK code at a different location than what is
grown a defacto standard in Linux distros. We should not follow this approach.
* Re "he used Ubuntu is outdated, we should use the 18.04 LTS release"
This has been corrected in an update to the PR
* Re "what about the Apache Yetus comment, seems to belong to another Docker image?"
This has been corrected in an update to the PR
* Re "the setup seems to add/install more than is needed"
Proposed Dockerfile is intended for testing and evaluation purposes, not for running a production
setup where some of the added packages may not be desired. For now, I suggest to go with it
as it is.

Regarding your other thoughts on using Dockerfiles for releases and moving it outside of the
codebase.
A release where this is incorporated is still far into future. But you're correct: before
we arrive on that moment this should be addressed. However, mature projects (visavis generating
docker images) tend to have a CI process in play that ensures that images generated automatically
use the code based on either branch or tag. We're not there yet. 

Having Dockerfile outside of the codebase has some negative side effects:
* we add additional complexity which needs to be communicated and maintained
* we add additional complexity in CI processes
For now I suggest the projects goes with this as it is, and as it matures it can decide where
the favourable location should be.





> create a docker image from the ofbiz system
> -------------------------------------------
>
>                 Key: OFBIZ-10407
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10407
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Hans Bakker
>            Priority: Major
>              Labels: DevOps
>         Attachments: docker.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Attached an initial docker version from OFBiz copied from our GrowERP production system
translated to svn repositories.
> I propose to create a docker directory in the ofbiz framework root of which a patch is
attached.
> The image result is stored in hub.docker.com under the name ofbiz/full-trunk.
> It can be started in a docker environment with the following command:
> docker run -p 80:8080 -p 443:8443 ofbiz/full-trunk
>  and after about 30 seconds it can be show in the browser under:
>  [https://0.0.0.0/catalog/control/main]
>  the image can be created by executing this command in the ofbiz root when the patch
is applied:
>  docker build -t ofbiz/full-trunk docker
> the password to the ofbiz account at hub.docker.com will be supplied upon request.
>   
> see the discussion in the mailinglist at https://markmail.org/message/n7wcgroslj7v3gfe?q=docker+ofbiz
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message