From notifications-return-30853-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Mon Feb 17 08:05:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7D954180675 for ; Mon, 17 Feb 2020 09:05:02 +0100 (CET) Received: (qmail 93578 invoked by uid 500); 17 Feb 2020 08:05:01 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 93568 invoked by uid 99); 17 Feb 2020 08:05:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Feb 2020 08:05:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E22FDE2E39 for ; Mon, 17 Feb 2020 08:05:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 2483D780703 for ; Mon, 17 Feb 2020 08:05:00 +0000 (UTC) Date: Mon, 17 Feb 2020 08:05:00 +0000 (UTC) From: "Jacques Le Roux (Jira)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038134#comment-17038134 ] Jacques Le Roux commented on OFBIZ-11229: ----------------------------------------- Here is the "UrlRegexpTransform vs OfbizUrlTransform classes" diff: [^OfbizUrlTransform vs UrlRegexpTransform.patch] > Merge UrlRegexpTransform and OfbizUrlTransform classes > ------------------------------------------------------ > > Key: OFBIZ-11229 > URL: https://issues.apache.org/jira/browse/OFBIZ-11229 > Project: OFBiz > Issue Type: Bug > Components: framework, product > Affects Versions: Trunk > Reporter: Jacques Le Roux > Assignee: Michael Brohl > Priority: Minor > Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch, OfbizUrlTransform vs UrlRegexpTransform.patch > > > This improvemnt follows Paul's suggestion and this discussion which contains other references: > https://markmail.org/message/bobj2uhnkzjddrtt. > Globally can be summarised by my comment in this thread: > bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used it everywhere. Now there are maybe few features in OfbizUrlTransform that are not in UrlRegexpTransform. That needs to be checked. If we can merge OfbizUrlTransform in UrlRegexpTransform then the later could be used everywhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)