From notifications-return-31740-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Wed Feb 26 21:31:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F237218065C for ; Wed, 26 Feb 2020 22:31:02 +0100 (CET) Received: (qmail 89811 invoked by uid 500); 26 Feb 2020 21:31:02 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 89800 invoked by uid 99); 26 Feb 2020 21:31:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Feb 2020 21:31:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 87FA6E3124 for ; Wed, 26 Feb 2020 21:31:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 4ED8E780631 for ; Wed, 26 Feb 2020 21:31:00 +0000 (UTC) Date: Wed, 26 Feb 2020 21:31:00 +0000 (UTC) From: "Pierre Smits (Jira)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OFBIZ-11030) Convert FactServices.xml minilang to groovy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-11030?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D170= 45911#comment-17045911 ]=20 Pierre Smits edited comment on OFBIZ-11030 at 2/26/20 9:30 PM: --------------------------------------------------------------- Thanks [~sberg], I did some aceptance testing with the changes, and it seems to look good. E= xcept for the loading of the InventoryItemFact entity. Compare=C2=A0OFBIZ-1= 1030-InventoryItemFact-test to=C2=A0OFBIZ-11030-InventoryItemFact-DemoTrunk= . Did you experience the same? Maybe you could have a look at this? And there are some flaws implemented previously (e.g. compare=C2=A0OFBIZ-11= 030-Order-SalesOrder-overview to=C2=A0OFBIZ-11030-SalesOrderItemFact-test, = where order DEMO10090 is not included in the SalesOrderItemFact, or the fla= ws in OFBIZ-11030-SalesInvoiceItemFact-test) With the GIGO (Garbage In Garbage Out) regarding the pre-change code the pr= oject should decide wether or not accept the migration. I suggest it should= , and deal with the bug fixes at a later date. was (Author: pfm.smits): Thanks [~sberg], I did some aceptance testing with the changes, and it seems to look good. E= xcept for the loading of the InventoryItemFact entity. Compare=C2=A0OFBIZ-1= 1030-InventoryItemFact-test to=C2=A0OFBIZ-11030-InventoryItemFact-DemoTrunk= . Maybe you could have a look at this? And there are some flaws implemented previously (e.g. compare=C2=A0OFBIZ-11= 030-Order-SalesOrder-overview to=C2=A0OFBIZ-11030-SalesOrderItemFact-test, = where order DEMO10090 is not included in the SalesOrderItemFact, or the fla= ws in OFBIZ-11030-SalesInvoiceItemFact-test) With the GIGO (Garbage In Garbage Out) regarding the pre-change code the pr= oject should decide wether or not accept the migration. I suggest it should= , and deal with the bug fixes at a later date. > Convert FactServices.xml minilang to groovy > ------------------------------------------- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi > Affects Versions: Trunk > Reporter: Pierre Smits > Assignee: Sebastian Berg > Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patc= h, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-Inven= toryItemFact-DemoTrunk.png, OFBIZ-11030-InventoryItemFact-test.png, OFBIZ-1= 1030-Order-SalesOrder-overview.png, OFBIZ-11030-SalesInvoiceItemFact-test.p= ng, OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.p= ng > > > With the purpose to deprecate mini-lang OFBIZ-9350, =C2=A0convert=C2=A0Fa= ctServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)