From notifications-return-30907-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Tue Feb 18 21:06:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0042D18060E for ; Tue, 18 Feb 2020 22:06:01 +0100 (CET) Received: (qmail 2165 invoked by uid 500); 18 Feb 2020 21:06:01 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 2155 invoked by uid 99); 18 Feb 2020 21:06:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2020 21:06:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 982C2E2E13 for ; Tue, 18 Feb 2020 21:06:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 14EE678033A for ; Tue, 18 Feb 2020 21:06:00 +0000 (UTC) Date: Tue, 18 Feb 2020 21:06:00 +0000 (UTC) From: "Michael Brohl (Jira)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039460#comment-17039460 ] Michael Brohl commented on OFBIZ-6705: -------------------------------------- This is hard to test. It seems there is no way to set the viewSize in the find views. From memory I would say they should be there but I am not sure. Setting the parameter in the Url provides unexpteced results. Need more time to figure out what's wrong. > some files set viewIndex to 1 by default rather than 0 > ------------------------------------------------------ > > Key: OFBIZ-6705 > URL: https://issues.apache.org/jira/browse/OFBIZ-6705 > Project: OFBiz > Issue Type: Improvement > Reporter: Gareth Carter > Assignee: Michael Brohl > Priority: Minor > Fix For: 17.12.01 > > Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch > > > The following files set viewIndex to 1 > {noformat} > ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java: if (viewIndex == null) viewIndex = 1; > ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl: <#--assign viewIndex = viewIndex - 1/--> > ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex = request.getParameter("viewIndex") ? Integer.valueOf(request.getParameter("viewIndex")) : 1; > ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex = 1; > ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1); > ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy: viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1); > {noformat} > I ran this command to get the output: > grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1" > As far as I am aware, viewIndex starts from 0 -- This message was sent by Atlassian Jira (v8.3.4#803005)