ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11335) Add CommonForms as template pattern configured by theme
Date Thu, 20 Feb 2020 13:52:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040985#comment-17040985

ASF subversion and git services commented on OFBIZ-11335:

Commit 1941a05a349865b8505ec373de3fce3b3a96c2a0 in ofbiz-framework's branch refs/heads/trunk
from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1941a05 ]

Improved: Manage VisualTheme in ModelForm

Related to issue OFBIZ-11335, extends form's factories and form's models
to support a visualTheme during the model creation.

This extend help centralize style information used by forms on a theme.
For performance reason when the model is loaded in memory, all theme information
need to be present to set immutable as possible to put it in cache
(implies why the key cache contains now the visualThemeId).

> Add CommonForms as template pattern configured by theme
> -------------------------------------------------------
>                 Key: OFBIZ-11335
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11335
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework, themes
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Major
>         Attachments: OFBIZ-11335.patch
> Currently on OFBiz we implemented a process to define some different screen and menu
that can be implemented by the theming
> But for the form we have nothing. All style are hard coded on each
> {code:java}
> <grid name="ListEntities" ...
>  odd-row-style="alternate-row" default-table-style="basic-table hover-bar">{code}
> I propose to extend the theming implementation principle to forms element.
> To start low, I define seven form tempates :
>  * grid CommonSimpleGrid
>  * grid CommonBasicGrid
>  * form CommonSimpleList
>  * form CommonBasicList
>  * form CommonInLineEditList
>  * form CommonSimpleSingle
>  * form CommonBasicSingle
> We can use its like :
> {code:java}
> <form name="LayoutDemoList" extends="CommonBasicList" extends-resource="component://common/widget/CommonForms.xml"{code}
> The main difficulty raise to this task was propage the visualTheme during the ModelForm
intanciation, because we need to load wiget style (and some other information wanted on the
template) on model load in memory. 
> With the linked patch I improved form present on screen 
> [https://localhost:8443/webtools/control/WebtoolsLayoutDemo]
> Finally with this we can extend style form (pagination, header, line and so on ...) direclty
by your theme without change the framework

This message was sent by Atlassian Jira

View raw message