ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11236) Add shipment notes
Date Tue, 11 Feb 2020 14:03:01 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034468#comment-17034468
] 

Michael Brohl commented on OFBIZ-11236:
---------------------------------------

{quote}As Jacques has told me a few times in the past 12 years (and I am paraphrasing here):
something done in less than 10 mins should be good enough for the next step.
{quote}
I do not think that this is a formula which is valid. Time should not be a factor when we
talk about a *new feature*.

Quality, consistency and completeness should be the main factors to review for new features.
If a feature is committed in an incomplete state it is likely to stay there in this state
for a long time. We struggle with these from time to time.

So if we have this new feature for shipment notes, it should be complete with create/update/delete
services and functionality in the UI to use them. It would not be complete if it would only
contain, say, a create shipment note funtionality only.

This should be worked out as long as it takes to be complete.

> Add shipment notes
> ------------------
>
>                 Key: OFBIZ-11236
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11236
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Gaudin Pierre
>            Priority: Minor
>              Labels: shipment
>         Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot 2020-02-11 at 08.53.37.png
>
>
> Hello,
> For many entities there are associated notes. However, there are no notes associated
with shipments.
> The purpose of this patch is therefore to add notes to the shipments.
> A new tab called "note" appears when displaying a shipment. From this tab it is possible
to add a note. From the shipment overview a section displays the notes associated with the
shipment.
> For this new feature a "ShipmentNote" entity has been added. In the same way, all the
services allowing the management of notes have been associated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message