ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
Date Sat, 01 Feb 2020 14:01:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028093#comment-17028093
] 

Michael Brohl commented on OFBIZ-10973:
---------------------------------------

Isn't the implementation explicitely for the third party provider msg91? IMO this is the same
case as a PayPal or WorldPay integration.

Renaming to just msggateway is more confusing because it reads as if it is a generic msg gateway
functionality.

I would suggest to rename it to msggateway-msg91 which allows to have other future msg gateway
components with the same naming scheme.

> Rename custom component for SMS gateway integration
> ---------------------------------------------------
>
>                 Key: OFBIZ-10973
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10973
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Pritam Kute
>            Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send sms".
> But could we not have another name, more explicit, for this component, like sms or sendsms
for instance?
> Services tend to disappear or change (Google is the best example). So I'd not associate
the name of an open source component to a commercial services  provider (with a free SMS quota
option). Even if hopefully it will stay as is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message