ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ankit Joshi (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10956) Have a service to load records in the CountryDimension
Date Sat, 22 Feb 2020 11:38:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042537#comment-17042537
] 

Ankit Joshi commented on OFBIZ-10956:
-------------------------------------

Hello [~pierresmits]/[~jacopoc],

I have reviewed the provided patch (https://github.com/apache/ofbiz-plugins/pull/4) to load
the CountryDimension records and found following gaps while testing:

-- The getDimensionRecord method is invoked in bi/groovyScripts/DwhDimensionServices.groovy.

(line no.28) but the method implementation is missing in the patch.

-- The loadCountryDimension script in bi/groovyScripts/DwhDimensionServices.groovy is creating
the record with 'country' as prefix for most of the field names that doesn't match with the
entity definition of the CountryDimension entity (line no.32 to line no.40).
  
I have added the fix for both of these gaps and able to verify the complete workflow with
these fixes in the development environment. Attached the updated patch for the review. Please
have a look at it.

-- Also, the patch doesn't contain the relevant field from CountryDimension entity to store
Geo.geoSecCode details. Could you please provide more details on it.

Thanks.

> Have a service to load records in the CountryDimension
> ------------------------------------------------------
>
>                 Key: OFBIZ-10956
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10956
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: bi
>    Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>            Reporter: Pierre Smits
>            Assignee: Ankit Joshi
>            Priority: Major
>              Labels: CountryDimension, birt, country, dimension, dwh, service
>
> Depending on [OFBIZ-10954|https://issues.apache.org/jira/browse/OFBIZ-10954]
> The service should be invoked on initialisation of the data warehouse.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message