ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre Smits (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10551) Remove unused labels from ProductUiLabels.xml
Date Mon, 17 Feb 2020 14:49:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038415#comment-17038415
] 

Pierre Smits commented on OFBIZ-10551:
--------------------------------------

Test result via local Yetus implementation:

{noformat}


+1 overall

 ____                              _ 
/ ___| _   _  ___ ___ ___  ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
 ___) | |_| | (_| (_|  __/\__ \__ \_|
|____/ \__,_|\___\___\___||___/___(_)
                                     


| Vote |      Subsystem |  Runtime   | Comment
============================================================================
|   0  |        reexec  |   0m 38s   | Docker mode activated. 
+---------------------------------------------------------------------------
|      |                |            | Prechecks 
+---------------------------------------------------------------------------
|  +1  |       dupname  |   0m  0s   | No case conflicting files found. 
|  +1  |       @author  |   0m  0s   | The patch does not contain any @author 
|      |                |            | tags.
+---------------------------------------------------------------------------
|      |                |            | tests Compile Tests 
+---------------------------------------------------------------------------
+---------------------------------------------------------------------------
|      |                |            | Patch Compile Tests 
+---------------------------------------------------------------------------
|  +1  |    whitespace  |   0m  0s   | The patch has no whitespace issues. 
|  +1  |           xml  |   0m  5s   | The patch has no ill-formed XML file. 
+---------------------------------------------------------------------------
|      |                |            | Other Tests 
+---------------------------------------------------------------------------
|   0  |    asflicense  |   1m  5s   | ASF License check generated no output? 
|      |                |  21m 56s   | 


|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=18.09.2 Server=18.09.2 base: /Users/nl04748/dev/test/yetus/ofbiz-10551-anon/Dockerfile
|
| GITHUB PR | https://github.com/apache/ofbiz-framework/pull/15 |
| Optional Tests | dupname asflicense xml |
| uname | Linux d7526df2953c 4.9.125-linuxkit #1 SMP Fri Sep 7 08:20:28 UTC 2018 x86_64 x86_64
x86_64 GNU/Linux |
| Build tool | gradle |
| Personality | personality/ofbiz.sh |
| git revision | tests / 969f48b |
| Max. process+thread count | 116 (vs. ulimit of 1000) |
| modules | C: . U: . |
| versions | git=2.7.4 gradle=5.0 |
| Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org |

{noformat}


> Remove unused labels from ProductUiLabels.xml
> ---------------------------------------------
>
>                 Key: OFBIZ-10551
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10551
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>         Attachments: OFBIZ-10551-ProductUiLabels.xml.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Component UI labels get added when code changes are introduced. But it can also happen
that the (unused) label is forgotten while doing code clean-ups, refactoring of the change
before a patch submitted or a commit is executed. Or that progressing insight leads to have
the code change go into a different component
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message