ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0
Date Sun, 09 Feb 2020 15:57:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033247#comment-17033247
] 

Michael Brohl commented on OFBIZ-6705:
--------------------------------------

Thanks, [~gareth.carter] ,

I repeated the grep command on current trunk and got:
{noformat}
~/Projects/apache-ofbiz/ofbiz-framework ⑂trunk  grep -R --exclude-dir=.svn "viewIndex
= " . | grep " 1"
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderLookupServices.java:
       Integer viewIndex = Paginator.getViewIndex(context, "viewIndex", 1);
./applications/order/groovyScripts/order/FindOrders.groovy:viewIndex = request.getParameter("viewIndex")
? Integer.valueOf(request.getParameter("viewIndex")) : 1
./applications/party/groovyScripts/visit/ShowVisits.groovy:    viewIndex = Integer.valueOf(parameters.VIEW_INDEX
 ?: 1)
./applications/party/groovyScripts/communication/ListCommunications.groovy:context.viewIndex
= 1{noformat}
I'll see if it has drawbacks to change these (mostly defaults/fallbacks) to 0 instead of 1.

> some files set viewIndex to 1 by default rather than 0
> ------------------------------------------------------
>
>                 Key: OFBIZ-6705
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6705
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Gareth Carter
>            Assignee: Gareth Carter
>            Priority: Minor
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:        if (viewIndex
== null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:        <#--assign
viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
= request.getParameter("viewIndex") ? Integer.valueOf(request.getParameter("viewIndex")) :
1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
= 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy:    viewIndex
= Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
           viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message