ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-5409) JSON Response does not set http status on error
Date Wed, 05 Feb 2020 10:29:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030532#comment-17030532
] 

ASF subversion and git services commented on OFBIZ-5409:
--------------------------------------------------------

Commit b2e3cc717dcea74110d4b152ae46a9a2b2c62a89 in ofbiz-framework's branch refs/heads/release17.12
from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b2e3cc7 ]

Fixed: impersonateLogin
(OFBIZ-5409)

I reopended this old issue because, while working on  OFBIZ-11329, I found that
userLogin and impersonateLogin should be removed from
jsonResponseFromRequestAttributes

Thanks: James Yong for pointing that out

# Conflicts:
#	framework/common/src/main/java/org/apache/ofbiz/common/CommonEvents.java


> JSON Response does not set http status on error
> -----------------------------------------------
>
>                 Key: OFBIZ-5409
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5409
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07,
Trunk
>            Reporter: Gareth Carter
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07,
17.12.01, 18.12.01
>
>         Attachments: CommonEvents.patch, OFBIZ-5409 - Remove internal attributes for
security reason and secure json get.patch, OFBIZ-5409 - Remove internal attributes for security
reason.patch, OFBIZ-5409 - Remove internal attributes for security reason.patch, before-after.diff
>
>
> When a json response is sent and there was an error in the service called, it does not
set the http status. Currently status code is always 200 but it might be more appropriate
to send an error code such as 500.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message