From notifications-return-30149-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Fri Jan 31 14:56:05 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9F2DF18037A for ; Fri, 31 Jan 2020 15:56:05 +0100 (CET) Received: (qmail 73099 invoked by uid 500); 31 Jan 2020 14:56:03 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 72713 invoked by uid 99); 31 Jan 2020 14:56:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Jan 2020 14:56:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 72A94E2585 for ; Fri, 31 Jan 2020 14:56:02 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 95A6D7822C5 for ; Fri, 31 Jan 2020 14:56:00 +0000 (UTC) Date: Fri, 31 Jan 2020 14:56:00 +0000 (UTC) From: "ASF subversion and git services (Jira)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027561#comment-17027561 ] ASF subversion and git services commented on OFBIZ-5048: -------------------------------------------------------- Commit 02d59bcd5b0b9040a2fda777d26c0879139ae646 in ofbiz-framework's branch refs/heads/release18.12 from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=02d59bc ] Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048) This change provides easier access to the FileItem by not wrapping it into a buffer. > Multi Part Input Parameters not Available in Groovy Event > --------------------------------------------------------- > > Key: OFBIZ-5048 > URL: https://issues.apache.org/jira/browse/OFBIZ-5048 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS > Affects Versions: Trunk > Reporter: Vikramjit Singh > Assignee: Michael Brohl > Priority: Major > Fix For: 17.12.01, Upcoming Branch, 18.12.01 > > Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, OFBIZ-5048V2.patch > > > If form is of type enctype="multipart/form-data" and we are handling it's submission through Groovy Event then in the parameters Map Ofbiz does not set the multipart input parameters from request parameters. > The same are available when multipart form submission is handled through service. > The reason being the code that sets the multipart parameters in request attribute is only available in ServiceEventHandler.java and in GroovyEventHandler the multipart are never set. > So I have created a method getMultiPartParameterMap in the class UtilHttp.java and put the common logic in that method so that when getCombinedMap method is called from the GroovEventHandler the method also call getMultiPartParameterMap and in the ServiceEventHandler I have written a call for getMultiPartParameterMap method. > I am attaching the Patch Kindly Verify the same. -- This message was sent by Atlassian Jira (v8.3.4#803005)