ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mathieu Lirzin (Jira)" <j...@apache.org>
Subject [jira] [Closed] (OFBIZ-11313) Parsing included controller files eagerly
Date Wed, 01 Jan 2020 13:53:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mathieu Lirzin closed OFBIZ-11313.
----------------------------------
    Fix Version/s: Upcoming Branch
       Resolution: Implemented

Thanks [~jamesyong] for the review.

> Parsing included controller files eagerly
> -----------------------------------------
>
>                 Key: OFBIZ-11313
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11313
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: 0001-Improved-Retrieve-the-included-controller-files-eage.patch,
0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch
>
>
> Controller configuration files have the ability to include other controllers which can
be useful to make the controller more modular and potentially reusable.
> Currently included controller files are retrieved lazily when reading the properties
from a controller configuration. This technique avoids unnecessary work at startup but in
this concrete case the gain in negligeable and has the drawback of requiring error handling
everytime a property is read which is cumbersome.
> As a consequence it would be better to parse included files eagerly at startup time to
be able to detect inclusion errors early and relaxing the error handling when reading properties
since all the sensible work will be done when instantiating the {{ControllerConfig}} object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message