From notifications-return-29655-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Mon Dec 30 09:00:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7CFE3180657 for ; Mon, 30 Dec 2019 10:00:02 +0100 (CET) Received: (qmail 81197 invoked by uid 500); 30 Dec 2019 09:00:01 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 81186 invoked by uid 99); 30 Dec 2019 09:00:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Dec 2019 09:00:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 21269E0C4B for ; Mon, 30 Dec 2019 09:00:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 50677780368 for ; Mon, 30 Dec 2019 09:00:00 +0000 (UTC) Date: Mon, 30 Dec 2019 09:00:00 +0000 (UTC) From: "Mathieu Lirzin (Jira)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OFBIZ-11313) Parsing included controller files eagerly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005209#comment-17005209 ] Mathieu Lirzin edited comment on OFBIZ-11313 at 12/30/19 8:59 AM: ------------------------------------------------------------------ I will commit [^0001-Improved-Retrieve-the-included-controller-files-eage.patch] and [^0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch] tomorrow unless somebody objects. Those patches can be applied using {{git am XXX.patch}} and must be applied in order. was (Author: mthl): I will commit [^0001-Improved-Retrieve-the-included-controller-files-eage.patch] and [^0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch] tomorrow unless somebody objects. Those patches can be applied using {{git am XXX.patch}} and should be applied in order. > Parsing included controller files eagerly > ----------------------------------------- > > Key: OFBIZ-11313 > URL: https://issues.apache.org/jira/browse/OFBIZ-11313 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: Trunk > Reporter: Mathieu Lirzin > Assignee: Mathieu Lirzin > Priority: Minor > Attachments: 0001-Improved-Retrieve-the-included-controller-files-eage.patch, 0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch > > > Controller configuration files have the ability to include other controllers which can be useful to make the controller more modular and potentially reusable. > Currently included controller files are retrieved lazily when reading the properties from a controller configuration. This technique avoids unnecessary work at startup but in this concrete case the gain in negligeable and has the drawback of requiring error handling everytime a property is read which is cumbersome. > As a consequence it would be better to parse included files eagerly at startup time to be able to detect inclusion errors early and relaxing the error handling when reading properties since all the sensible work will be done when instantiating the {{ControllerConfig}} object. -- This message was sent by Atlassian Jira (v8.3.4#803005)