ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mathieu Lirzin (Jira)" <j...@apache.org>
Subject [jira] [Closed] (OFBIZ-11019) Cleaning the bloated ‘Security’ interface
Date Sat, 07 Dec 2019 17:13:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mathieu Lirzin closed OFBIZ-11019.
----------------------------------
    Resolution: Later

I think a more global approach should be taken on the rewrite of the {{Security}} interface,
as a consequence I withdraw my patch proposal.

> Cleaning the bloated ‘Security’ interface
> -----------------------------------------
>
>                 Key: OFBIZ-11019
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11019
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>         Attachments: OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch
>
>
> The ‘hasPermission(String, HttpSession)’ method declaration from the ‘Security’
interface is breaking the minimality principle of interfaces because it is easily expressible
in term of ‘hasPermission(String, GenericEntity)’. As a consequence a static helper method
should be implemented to achieve same convenience without polluting the ‘Security’ interface.
> Other methods in that interface are suffering from the same issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message