ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mathieu Lirzin (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool
Date Sat, 19 Oct 2019 11:35:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955146#comment-16955146
] 

Mathieu Lirzin commented on OFBIZ-11251:
----------------------------------------

In fact this build error is a good thing. :-)

Let me explain. the commit [trunk@1868611|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868611]
done for OFBIZ-10284 has introduced some Java code that do not conform to the checkstyle specification
and {{gradlew build}} which is run by Buildbot triggers the {{:check}} task which mean that
it detects coding conventions mistakes with build failures.

I will fix the coding conventions mistakes introduced by [trunk@1868611|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868611]
.

> Use ‘checkstyle’ linting tool
> -----------------------------
>
>                 Key: OFBIZ-11251
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11251
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch
>
>
> Linting [1] is a software engineering practice which make the code
> more readable and maintainable by improving its consistency and
> avoiding potential programming mistakes.
> Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which
> provides such facility.  The lint actions are triggered when running
> ‘gradle check’.
> There are a lot reported errors that will need to be fixed
> incrementally in the future.  We ensure that new errors will not be
> introduced by defining a global threshold of “allowed” errors
> corresponding to the sum of errors currently found in the framework
> and in the official plugins.
> [1] https://en.wikipedia.org/wiki/Lint_(software)
> [2] https://checkstyle.org/
> [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message