ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Malin (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
Date Fri, 04 Oct 2019 12:45:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944468#comment-16944468
] 

Nicolas Malin commented on OFBIZ-11229:
---------------------------------------

To solve issue OFBIZ-4361 I create a first version to merge  OfbizUrlTransform in UrlRegexpTransform,
the main identify point was when the request isn't present (email send, service call) the
website isn't pull from context. It's solve with this patch  [^OFBIZ-11229-mergeUrlRegexpTransform.patch]


> Merge UrlRegexpTransform and OfbizUrlTransform classes
> ------------------------------------------------------
>
>                 Key: OFBIZ-11229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework, product
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch
>
>
> This improvemnt follows Paul's suggestion and this discussion which contains other references:
> https://markmail.org/message/bobj2uhnkzjddrtt.
> Globally can be summarised by my comment in this thread:
> bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used it everywhere.
Now there are maybe few features in OfbizUrlTransform that are not in UrlRegexpTransform.
That needs to be checked. If we can merge OfbizUrlTransform in UrlRegexpTransform then the
later could be used everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message