ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-8341) Fix Default or Empty Catch block in Java and Groovy files
Date Sat, 14 Sep 2019 17:14:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929792#comment-16929792
] 

Jacques Le Roux commented on OFBIZ-8341:
----------------------------------------

At revision: 1866952  I made some other changes.  Remains 25 cases, most don't need change,
so we should be able to close soon...


> Fix Default or Empty Catch block in Java and Groovy files
> ---------------------------------------------------------
>
>                 Key: OFBIZ-8341
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8341
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>            Reporter: Harsh Vijaywargiya
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-8341- OrderReadHelper.patch
>
>
> In many Java and Groovy files we have auto generated catch blocks or empty catch blocks.

> To avoid such exception swallowing this should be improved to at least log the error
and also return error in case of service.
> As of now I found following classes with such patterns - 
> InventoryServices.java
> FreeMarkerWorker.java
> QRCodeEvents.java
> QRCodeServices.java



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message