ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
Date Sun, 11 Aug 2019 13:00:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904638#comment-16904638
] 

Jacques Le Roux commented on OFBIZ-10145:
-----------------------------------------

At r1864927 I have added the Windows init-gradle-wrapper scripts (both .bat et .ps1) in all
concerned branch (trunk, R18, R17)

These are very simple because I believe (almost?) nobody is using a Windows server to deploy
OFBiz in production. So they will be only used in development environment. In case deployment
in production is needed they supply a base to work on...

The init-gradle-wrapper.ps1 scripts use only HTTP and not HTTPS because it's very difficult
to handle all the issues related with different versions of Powershell and .net in different
versions of Windows. Better to let that to deployment in case it's really needed...


> Remove the Gradle wrapper from our release packages and add a step to our build notes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10145
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10145
>             Project: OFBiz
>          Issue Type: Task
>          Components: Gradle
>    Affects Versions: 17.12.01, 16.11.06, 18.12.01
>            Reporter: Jacques Le Roux
>            Assignee: Nicolas Malin
>            Priority: Blocker
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-10145-gradlew.patch, OFBIZ-10145_wrapper_properties_check.patch,
gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh,
init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat,
init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch,
init-gradlew-readme.patch, init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, considering
LEGAL-288 and based on a lazy consensus on dev ML, we want to remove the gradle-wrapper.jar
file from the next packaged releases and  use [~jacopoc]'s related proposition to document
how to have Gradle working in the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the gradle-wrapper.jar. This might
change in the future (versions, etc.), so indeed maybe simply asking to download is enough,
cf  https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message