From notifications-return-27223-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Sat Jun 22 09:16:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 512261807A0 for ; Sat, 22 Jun 2019 11:16:02 +0200 (CEST) Received: (qmail 90323 invoked by uid 500); 22 Jun 2019 09:16:01 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 90305 invoked by uid 99); 22 Jun 2019 09:16:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Jun 2019 09:16:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D49EFE2DE9 for ; Sat, 22 Jun 2019 09:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4C9F225455 for ; Sat, 22 Jun 2019 09:16:00 +0000 (UTC) Date: Sat, 22 Jun 2019 09:16:00 +0000 (UTC) From: "Rohit Hukkeri (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-10150?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D168= 70152#comment-16870152 ]=20 Rohit Hukkeri commented on OFBIZ-10150: --------------------------------------- Hello,=C2=A0 I have added patch with required type change for the data field "supplierPr= oductId" to make it consist across entities. Regards, Rohit Hukkeri > supplierProductId Should Have Consistent Types Across Entities. > --------------------------------------------------------------- > > Key: OFBIZ-10150 > URL: https://issues.apache.org/jira/browse/OFBIZ-10150 > Project: OFBiz > Issue Type: Improvement > Components: order, product > Affects Versions: Trunk > Environment: all > Reporter: jesse thomas > Assignee: Rohit Hukkeri > Priority: Minor > Attachments: OFBIZ-10150.patch > > > During some data migration I hit an issue where my data for supplierProdu= ctId was too long. So I looked up the fields and noticed that the order ite= m entity had a different type for the field than the supplier product entit= y. I think it would be a good idea to pick one so the two fields can be tre= ated consistently. I would vote for id-long, but I think either way it woul= d be good to have them be the same type. There are other fields that have t= his issue too if you are interested? > =20 > Thanks! > applications/datamodel/entitydef/order-entitymodel.xml: =20 > > applications/datamodel/entitydef/product-entitymodel.xml: =20 > -- This message was sent by Atlassian JIRA (v7.6.3#76005)