From notifications-return-26822-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Sun Jun 2 10:42:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6C96618064E for ; Sun, 2 Jun 2019 12:42:03 +0200 (CEST) Received: (qmail 33878 invoked by uid 500); 2 Jun 2019 10:42:02 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 33869 invoked by uid 99); 2 Jun 2019 10:42:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Jun 2019 10:42:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A7373E0A4B for ; Sun, 2 Jun 2019 10:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E917C2459B for ; Sun, 2 Jun 2019 10:42:00 +0000 (UTC) Date: Sun, 2 Jun 2019 10:42:00 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-10145?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D168= 53947#comment-16853947 ]=20 Jacques Le Roux commented on OFBIZ-10145: ----------------------------------------- I had another even simpler idea. Why bother Infra? We can simply copy the O= FBiz/gradle/wrapper directory in tools/buildbot/gradle/wrapper and in Build= bot copy it back to its place, et voil=C3=A0. I have closed INFRA-18530 with more information there, actually copying it= here: bq. I forgot that we have Gradle installed in /usr/lib/gradle/ on "lares_ub= untu" , "orcus_ubuntu" , "silvanus_ubuntu"=C2=A0 as says INFRA-13202. Actua= lly It's about Gradle to 3.2.1, I guess it's the same for Gradle 5.0. I'll work on https://svn.apache.org/repos/infra/infrastructure/buildbot/aeg= is/buildmaster/master1/projects/ofbiz.conf soon... > Remove the Gradle wrapper from our release packages and add a step to our= build notes > -------------------------------------------------------------------------= ------------ > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle > Affects Versions: 17.12.01, 16.11.06, 18.12.01 > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, init-gradle-wra= pper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrap= per-trunk-and-18.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-g= radle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-grad= lew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readm= e.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,= considering LEGAL-288 and based on a lazy consensus on dev ML, we want to = remove the gradle-wrapper.jar file from the next packaged releases and use= [~jacopoc]'s related proposition to document how to have Gradle working in= the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/w= rapper folder. > I'm not sure if we should recommend a link to download the gradle-wrapper= .jar. This might change in the future (versions, etc.), so indeed maybe sim= ply asking to download is enough, cf https://www.google.com/search?q=3Dgra= dle-wrapper.jar+download&ie=3DUTF-8 > Also we need to add a point about removing gradle-wrapper.jar in https://= cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBi= z -- This message was sent by Atlassian JIRA (v7.6.3#76005)