ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deepak Nigam (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-10639) Cookie Consent In E-Commerce
Date Thu, 13 Jun 2019 09:10:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862847#comment-16862847
] 

Deepak Nigam edited comment on OFBIZ-10639 at 6/13/19 9:09 AM:
---------------------------------------------------------------

Thanks [~aditya.sharma] and [~jacques.le.roux]. 

Please find responses to your queries and suggestions below:

 

_"I think we should avoid renaming the external library and its variable names (ihavecookies).
Apart from this we should not modify its headers. As per my understanding license headers
are added for custom files specific to OFBiz and external files are kept as it is."_

By keeping in mind about MIT license, I changed the name of variables to make them more relevant
to the functionality. However, we can keep the previous name also. I also removed some code
from the plugin which is not required in our case. I am not sure if we can add OFBiz license
header files for the customized files having MIT license. Please help me with this.

 

_"Also we should provide not only the minified library but also its plain source code version"_

I will add the plain source code file also.

 

_"are the changes in custom.css custom or copied from the ihavecookies project (example.css
file)? "_

Changes in custom.css files are copied from Example.css but I made some customizations for
a better look and feel.

 

_"And last but not least we prefer to generate our patches from root, easier for reviewers
to apply and test"_

This patch was created from the root of the e-commerce plugin. I am able to apply it from
there.

 

_"Could you explain why init.js would be better than eg InitCookieConsent.js for new custom
code. It's not clear to me and I would prefer the later."_

By custom code in Init.js, I mean initialization blocks of other plugins and libraries. It
will be a common file for all initialization blocks. However, InitCookieConsent.js is also
fine we want to keep it specific to this cookie consent feature.

 

 

 

 

 

 


was (Author: deepak.nigam):
Thanks [~aditya.sharma] and [~jacques.le.roux]. 

Please find responses to your queries and suggestions below:

 

_"I think we should avoid renaming the external library and its variable names (ihavecookies).
Apart from this we should not modify its headers. As per my understanding license headers
are added for custom files specific to OFBiz and external files are kept as it is."_

By keeping in mind about MIT license, I changed the name of variables to make them more relevant
to the functionality. However, we can keep the previous name also. I also removed some code
from the plugin which is not required in our case. I am not sure if we can add OFBiz license
header files for the customized files having MIT license. Please help me with this.

 

_"Also we should provide not only the minified library but also its plain source code version"_

I will add the plain source code file also.

 

_"are the changes in custom.css custom or copied from the ihavecookies project (example.css
file)? "_

Changes in custom.css files are copied from Example.css but I made some customizations for
a better look and feel.

 

_"And last but not least we prefer to generate our patches from root, easier for reviewers
to apply and test"_

This patch was created from the root of the e-commerce component. I am able to apply it from
there.

 

_"Could you explain why init.js would be better than eg InitCookieConsent.js for new custom
code. It's not clear to me and I would prefer the later."_

By custom code in Init.js, I mean initialization blocks of other plugins and libraries. It
will be a common file for all initialization blocks. However, InitCookieConsent.js is also
fine we want to keep it specific to this cookie consent feature.

 

 

 

 

 

 

> Cookie Consent In E-Commerce
> ----------------------------
>
>                 Key: OFBIZ-10639
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10639
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: Trunk
>            Reporter: Deepak Nigam
>            Assignee: Swapnil M Mane
>            Priority: Minor
>         Attachments: OFBIZ-10639.patch, OFBIZ-10639.patch
>
>
> As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] 
> The Cookie Law is a piece of privacy legislation that requires websites to get consent
from visitors to store or retrieve any information on their computer, smartphone or tablet.
It was designed to protect online privacy, by making consumers aware of how information about
them is collected and used online, and give them a choice to allow it or not. 
>   
>  The EU Cookie Legislation began as a directive from the European Union. Some variation
on the policy has since been adopted by all countries within the EU.
>   
>  The EU Cookie Legislation requires 4 actions from website owners who use cookies:
>  1. When someone visits your website, you need to let them know that your site uses cookies. 
>  2. You need to provide detailed information regarding how that cookie data will be utilized. 
>  3. You need to provide visitors with some means of accepting or refusing the use of
cookies in your site. 
>  4. If they refuse, you need to ensure that cookies will not be placed on their machine.
>  
>  For more information about EU cookie policy, please visit [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm].
>   
>  As this crucial feature is missing in OFBiz E-Commerce application, we should work towards
its implementation. There are numerous open-source jQuery plugins available which we can use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message