ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
Date Wed, 19 Jun 2019 13:42:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867630#comment-16867630
] 

Jacques Le Roux commented on OFBIZ-10145:
-----------------------------------------

Nicolas,

I was looking at what to do for Windows and I still think my proposition is good. Why? The
argument you had, and I agreed about:
bq. this introduce a hard rule for future to keep it during all time that a release version
would be present on support.
but actually we need to do that for Buildbot at least, as shown above, so our users can also
use it.

I also like the idea of (quoting myself):
bq. call our init-gradle-wrapper scripts from both gradlew and gradlew.bat script if the Wrapper
is not present. Then no need to ask our users to run the init-gradle-wrapper by hand. Using
the starting script (gradlew or gradlew.bat) [is] enough.

As said Swapnil about that:
bq. In this way, life our users will became easy, no action will be required from their side.


Don't you think we can should that?

Anyway I let the community decide for this aspect. I'll use it to handle the WIndows side.
I'll soon provide the patches for all branches.


> Remove the Gradle wrapper from our release packages and add a step to our build notes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10145
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10145
>             Project: OFBiz
>          Issue Type: Task
>          Components: Gradle
>    Affects Versions: 17.12.01, 16.11.06, 18.12.01
>            Reporter: Jacques Le Roux
>            Assignee: Nicolas Malin
>            Priority: Blocker
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme-R16.patch,
init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, considering
LEGAL-288 and based on a lazy consensus on dev ML, we want to remove the gradle-wrapper.jar
file from the next packaged releases and  use [~jacopoc]'s related proposition to document
how to have Gradle working in the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the gradle-wrapper.jar. This might
change in the future (versions, etc.), so indeed maybe simply asking to download is enough,
cf  https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message