ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swapnil M Mane (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
Date Sat, 08 Jun 2019 10:06:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859169#comment-16859169
] 

Swapnil M Mane edited comment on OFBIZ-10145 at 6/8/19 10:05 AM:
-----------------------------------------------------------------

Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script
from both gradlew and gradlew.bat script. In this way, life our users will became easy, no
action will be required from their side. 

And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper'
script always while upgrading the gradle.

Just I am not sure about recommendation for customizing the Gradle Wrapper file.

Let's see what are the thoughts our fellow team members.

Thanks!


was (Author: swapnilmmane):
Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script
from both gradlew and gradlew.bat script. In this way, life our users will became easy, no
action will be required from their side. 

And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper'
script always while upgrading the gradle.

Let's see what are the thoughts our fellow team members.


Thanks!

> Remove the Gradle wrapper from our release packages and add a step to our build notes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10145
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10145
>             Project: OFBiz
>          Issue Type: Task
>          Components: Gradle
>    Affects Versions: 17.12.01, 16.11.06, 18.12.01
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Blocker
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, considering
LEGAL-288 and based on a lazy consensus on dev ML, we want to remove the gradle-wrapper.jar
file from the next packaged releases and  use [~jacopoc]'s related proposition to document
how to have Gradle working in the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the gradle-wrapper.jar. This might
change in the future (versions, etc.), so indeed maybe simply asking to download is enough,
cf  https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message