From notifications-return-25988-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Mon May 13 08:32:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E5BF2180675 for ; Mon, 13 May 2019 10:32:01 +0200 (CEST) Received: (qmail 35375 invoked by uid 500); 13 May 2019 08:32:01 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 35355 invoked by uid 99); 13 May 2019 08:32:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 May 2019 08:32:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7EDF5E2B60 for ; Mon, 13 May 2019 08:32:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3364A25815 for ; Mon, 13 May 2019 08:32:00 +0000 (UTC) Date: Mon, 13 May 2019 08:32:00 +0000 (UTC) From: "Mathieu Lirzin (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838369#comment-16838369 ] Mathieu Lirzin edited comment on OFBIZ-10934 at 5/13/19 8:31 AM: ----------------------------------------------------------------- Hello, the [^OFBIZ10934-MORE.patch] contains some unrelated using {{Random#nextDouble}} instead of {{Math#random. Can you remove those?}} Personally I would find it more easy to review, if your patches were merged (meaning removing the old one and replacing it with an updated one) Thanks in advance. was (Author: mthl): Hello, the [^OFBIZ10934-MORE.patch] contains some unrelated using {{Random#nextDouble}} instead of {{Math#random. Can you remove those?}} Personally I would find it more easy to review, if your patches were merge (meaning removing the old one and replacing it with an updated one) Thanks in advance. > Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance > ------------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-10934 > URL: https://issues.apache.org/jira/browse/OFBIZ-10934 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Trunk > Reporter: bd2019us > Priority: Trivial > Labels: pull-request-available > Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files > > > Affected files: > # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java > # framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java > # framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java > # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java > When replaceAll() is utilized and no regex is used, replaceAll() can be replaced with replace() for better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)