ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy
Date Sun, 26 May 2019 10:39:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jacques Le Roux closed OFBIZ-11064.
-----------------------------------
       Resolution: Implemented
    Fix Version/s: Upcoming Branch

Thanks Pawan,

Your patch is in trunk at 1860051  

I just removed WebSiteForms.xml that you inadvertently added to the framework patch ;)


> Use Groovy Truth instead of UtilValidate Class in Groovy
> --------------------------------------------------------
>
>                 Key: OFBIZ-11064
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11064
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Pawan Verma
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-11064-plugins.patch, OFBIZ-11064.patch, OFBIZ-11064.patch
>
>
> As we all know, Groovy is a powerful language with great built-in functions. Groovy Truth[1]
is one of them, which is not used properly in our code base. We have used UtilValidate Class
to validate arguments for Empty or NotEmpty, which can easily be done in groovy with built-in
functionality.
>  
> Current Code: if (UtilValidate.isNotEmpty(locations)) \{ ... }
>  
> Groovy Built-in Code: if (locations) \{ ... }
>  
> IMO, We should use this Groovy Truth feature instead of UtilValidate Class. Please let
me know your thoughts on this. Thanks!
> [1] - [http://groovy-lang.org/semantics.html#Groovy-Truth]
>  
> We need to careful for some points while we change this:
> Like:
> maxRetry = 0
> if (!maxRetry) {
>  // Not set, use a default
>  maxRetry = -1
> }
> Because groovy evaluates zero to be false, it wouldn't be possible to set
> maxRetry to zero.  So it's best not to use groovy truth for null-checks on
> numbers in some cases. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message