ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swapnil M Mane (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
Date Mon, 27 May 2019 05:42:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848625#comment-16848625
] 

Swapnil M Mane edited comment on OFBIZ-10145 at 5/27/19 5:41 AM:
-----------------------------------------------------------------

Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be 3.2.1 (I have
done the suggested change in script and uploaded it again)

Hello [~soledad] and team,
I have done the following changes in script, please have a look

For R17 -  [^init-gradle-wrapper.sh] 
For R18 and trunk - [^init-gradle-wrapper-trunk-and-18.sh]

1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have changed the GRADLE_WRAPPER_OFBIZ_PATH
from 
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect....", even when run
from OFBiz root.

 

2.) Changed the Gradle release to 3.2.1 for R17.

3.) Done some improvements in messages which is to be shown to the user.

Please have a look and let me know your thoughts.
Thanks!
 


was (Author: swapnilmmane):
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be 3.2.1 (I have
done the suggested change in script and uploaded it again)

Hello [~soledad] and team,
I have done the following changes in script, please have a look

1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have changed the GRADLE_WRAPPER_OFBIZ_PATH
from 
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect....", even when run
from OFBiz root.

 

2.) Changed the Gradle release to 3.2.1 for R17.

3.) Done some improvements in messages which is to be shown to the user.

Please have a look and let me know your thoughts.
Thanks!

 

 

> Remove the Gradle wrapper from our release packages and add a step to our build notes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10145
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10145
>             Project: OFBiz
>          Issue Type: Task
>          Components: Gradle
>    Affects Versions: 17.12.01, 16.11.06, 18.12.01
>            Reporter: Jacques Le Roux
>            Assignee: Nicolas Malin
>            Priority: Blocker
>             Fix For: 17.12.01
>
>         Attachments: init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
init-gradle-wrapper.sh, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, considering
LEGAL-288 and based on a lazy consensus on dev ML, we want to remove the gradle-wrapper.jar
file from the next packaged releases and  use [~jacopoc]'s related proposition to document
how to have Gradle working in the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the gradle-wrapper.jar. This might
change in the future (versions, etc.), so indeed maybe simply asking to download is enough,
cf  https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message