ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
Date Sun, 26 May 2019 12:19:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848415#comment-16848415

Jacques Le Roux commented on OFBIZ-7963:

bq. Due to secret key(s) required by SonarCloud.io this service will not work (ever) when
done locally. You don't share secret keys with just anybody. The risk of the result getting
messed is ever present.
Hu?  I don't get it, the sonarqube task runs locally, even if it reports an error.

bq. What you're referring to are missing inclusion/exclusion aspects. These should (must??)
not be included in the gradle task, but should rather be included in the CI setup (as parameters)
to ensure flexibility.
Which flexibility are your referring about? The code structure is the same locally or on Buildbot.
I don't see a reason it would not work locally. We don't use Buildbot specific parameters
so far, all tasks are usable locally. How could we test them before committing else?

> Create a Gradle Sonar task
> --------------------------
>                 Key: OFBIZ-7963
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7963
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Pierre Smits
>            Priority: Minor
>         Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch
> As ever the devil is in details. There is no longer a Sonar plugin available https://docs.gradle.org/current/userguide/sonar_plugin.htmland
we should rather refer to http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590

This message was sent by Atlassian JIRA

View raw message