ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rishi Solanki (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-10973) Rename custom component for SMS gateway integration
Date Sun, 28 Apr 2019 11:07:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827871#comment-16827871
] 

Rishi Solanki edited comment on OFBIZ-10973 at 4/28/19 11:06 AM:
-----------------------------------------------------------------

[~pritam.kute]

I have committed the base changes in revision 1858279, 1858307, 1858308, and 1858311. Please
do the planned changes as per your plan. Thanks for your contribution.


was (Author: rishisolankii):
[~pritam.kute]

I have committed the base changes in revision 1858279 and 1858307. Please do the planned changes
as per your plan. Thanks for your contribution.

> Rename custom component for SMS gateway integration
> ---------------------------------------------------
>
>                 Key: OFBIZ-10973
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10973
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Pritam Kute
>            Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send sms".
> But could we not have another name, more explicit, for this component, like sms or sendsms
for instance?
> Services tend to disappear or change (Google is the best example). So I'd not associate
the name of an open source component to a commercial services  provider (with a free SMS quota
option). Even if hopefully it will stay as is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message