ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mathieu Lirzin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10933) Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’
Date Sat, 27 Apr 2019 19:05:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827727#comment-16827727
] 

Mathieu Lirzin commented on OFBIZ-10933:
----------------------------------------

Hello Jacques,

I see this warnings when compiling with IcedTea 3.7 (jdk8), but not with OpenJDK 11 neither
with Eclipse compiler, which is why I overlooked them. I suspect this is a false positive
where {{@safevarargs}} and generics don't play well together.

Since in that particular case no genericity required by the tests, we can workaround the warning
by removing the generic types.  If you agree with the strategy I will commit a fix.

Thanks.

> Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-10933
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10933
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 18.12
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Major
>             Fix For: Trunk, Release Branch 18.12
>
>         Attachments: OFBIZ-10933_0001-Improved-Add-UtilMisc-toMap-Supplier-Map-K-V-Object.patch,
OFBIZ-10933_0002-Fixed-Ensure-that-MapContext-preserves-insertion-ord.patch
>
>
> Since revision 1837462, when pushing a ‘LinkedHashMap’ inside a ‘MapContext’,
the iteration order of the ‘MapContext’ values is not corresponding to the
> insertion order of the embedded ‘LinkedHashMap’ which is important in the ‘ControllerConfig’
case where configuration elements are stored in ‘LinkedHashMap’ objects and the ‘include’
mechanism relies on ‘MapContext’.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message