ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Malin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10929) Duplicate a ShoppingCartItem didn't propage OrderItemAttributes
Date Tue, 16 Apr 2019 19:33:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819430#comment-16819430
] 

Nicolas Malin commented on OFBIZ-10929:
---------------------------------------

Commit the correction at revision :
 * trunk : 1857657
 * 18.12 : 1857658
 * 17.12 : 1857659
 * 16.10 : 1857660

> Duplicate a ShoppingCartItem didn't propage OrderItemAttributes
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-10929
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10929
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk, 17.12.01, 16.11.05, 18.12.01
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>
> When you clone a ShoppingCartItem by constructor
> {code:java}
> new ShoppingCartItem(ShoppingCartItem item){code}
> Values contains on list OrderItemAttributes aren't propage to the new shoppingCartItem
due to (ShoppingCartItem.java:682)
> {code:java}
> if (UtilValidate.isEmpty(item.getOrderItemAttributes())) {
>  this.orderItemAttributes = new HashMap<>();
>  this.orderItemAttributes.putAll(item.getOrderItemAttributes());
> }
> {code}
> isEmpty instead of isNotEmpty



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message