ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deepak Dixit (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service
Date Fri, 12 Apr 2019 08:09:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816067#comment-16816067
] 

Deepak Dixit commented on OFBIZ-9551:
-------------------------------------

Patch looks good to me, One minor improment can be done, we can use marketingPermissionService
instead required-permissions.

<permission-service service-name="marketingPermissionService" main-action="CREATE"/>

I'll commit patch with suggested changes. 

> Convert createMarketingCampaignRole service to entity-auto service
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-9551
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9551
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: marketing
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Deepak Dixit
>            Priority: Major
>         Attachments: OFBIZ-9551-simple.patch, OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at CampaignServices.xml
which is of no use and can be deleted, we can move that code to a separate permission check
service that can be used elsewhere as well.
> Also, this pattern is currently used in other areas like Party etc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message