ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10753) Improve error message page to support Theming
Date Wed, 27 Mar 2019 14:21:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802845#comment-16802845
] 

Jacques Le Roux commented on OFBIZ-10753:
-----------------------------------------

Hi Nicolas,

I'm not sure it's related (I think not, could be setting on image locally, I don't see the
same on the demo server) but could you please check if you don't get this error locally when
the error page pops up


{noformat}
2019-03-27 15:12:30,863 |jsse-nio-8443-exec-7 |ControlServlet                |E| Error in
request handler:
org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request [images]; this request
does not exist or cannot be called directly.
        at org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
~[ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) [ofbiz.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) [javax.servlet-api-4.0.1.jar:4.0.1]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) [javax.servlet-api-4.0.1.jar:4.0.1]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) [tomcat-embed-websocket-9.0.16.jar:9.0.16]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
[ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
[ofbiz.jar:?]
        at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) [javax.servlet-api-4.0.1.jar:4.0.1]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) [tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) [tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
[tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) [tomcat-catalina-9.0.16.jar:9.0.16]
        at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408) [tomcat-coyote-9.0.16.jar:9.0.16]
        at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
[tomcat-coyote-9.0.16.jar:9.0.16]
        at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:834)
[tomcat-coyote-9.0.16.jar:9.0.16]
        at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1415)
[tomcat-coyote-9.0.16.jar:9.0.16]
        at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
[tomcat-coyote-9.0.16.jar:9.0.16]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[?:1.8.0_202]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[?:1.8.0_202]
        at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[tomcat-util-9.0.16.jar:9.0.16]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
2019-03-27 15:12:30,864 |jsse-nio-8443-exec-7 |ControlServlet                |E| An error
occurred, going to the errorPage: file:/C:/projectsASF/ofbiz/framework/common/webcommon/error/Error.ftl
{noformat}

Thanks!

> Improve error message page to support Theming
> ---------------------------------------------
>
>                 Key: OFBIZ-10753
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10753
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Major
>         Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> <errorpage>/error/error.jsp</errorpage>{code}
> This method isn't support by the theming. I propose two improvements :
>  * use FlexibleLocation to resolve the error page :
> {code:java}
> <errorpage>component://common/webcommon/error/error.ftl</errorpage>{code}
>  * improve theme to support the error message page   
> {code:java}
>   <template name="screen" type="html" content-type="UTF-8" encoding="none" encoder="html"
compress="false">
>   <template-file widget="screen" location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
>   <template-file widget="form" location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
>   <template-file widget="tree" location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
>   <template-file widget="menu" location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + <template-file widget="error" location="component://common-theme/template/ErrorPage.ftl"/>
> </template>{code}
> By the way you can define your error page by the theme in first step and we would use
the rendering type in future to display the error no only in html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message