From notifications-return-23886-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Mon Feb 11 09:48:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id ADA65180648 for ; Mon, 11 Feb 2019 10:48:03 +0100 (CET) Received: (qmail 37985 invoked by uid 500); 11 Feb 2019 09:48:02 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 37975 invoked by uid 99); 11 Feb 2019 09:48:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2019 09:48:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 65E5AC2219 for ; Mon, 11 Feb 2019 09:48:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id VXW8q6lEhcCq for ; Mon, 11 Feb 2019 09:48:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9A359623FE for ; Mon, 11 Feb 2019 09:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 43AD6E0147 for ; Mon, 11 Feb 2019 09:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 102BB24467 for ; Mon, 11 Feb 2019 09:48:00 +0000 (UTC) Date: Mon, 11 Feb 2019 09:48:00 +0000 (UTC) From: "Swapnil M Mane (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (OFBIZ-10832) simpleTypeConvert always returns Null for Document, Document Type and Notation Node MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Swapnil M Mane created OFBIZ-10832: -------------------------------------- Summary: simpleTypeConvert always returns Null for Document, Document Type and Notation Node Key: OFBIZ-10832 URL: https://issues.apache.org/jira/browse/OFBIZ-10832 Project: OFBiz Issue Type: Bug Affects Versions: Release Branch 16.11, Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Swapnil M Mane Assignee: Swapnil M Mane simpleTypeConvert always returns Null for Document, Document Type and Notation Node The ObjectType.simpleTypeConvert method always returns null for Document, Document Type and Notation Node. As per the current code, getTextContent() method is used get text content of the node and its descendants but the node.getTextContent() always return Null for the following Node type DOCUMENT_NODE, DOCUMENT_TYPE_NODE, NOTATION_NODE [1] {code:java} if (obj instanceof Node) { Node node = (Node) obj; String nodeValue = node.getTextContent(); if ("String".equals(type) || "java.lang.String".equals(type)) { return nodeValue; } return simpleTypeConvert(nodeValue, type, format, timeZone, locale, noTypeFail); } {code} Since we can't get the text value of Document, Document Type and Notation Node, we should simply return the same object. [1] [https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Node.html#getTextContent(]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)