ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10337) Check for only QOH while doing reservations
Date Sun, 15 Apr 2018 08:26:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438629#comment-16438629

Jacques Le Roux commented on OFBIZ-10337:

While at it, I found Swapnil's message interesting and Rishi's related one promising. Should
we not create a Jira for that, in order to not forget the idea?

> Check for only QOH while doing reservations
> -------------------------------------------
>                 Key: OFBIZ-10337
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10337
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-10337.patch
> While checking around code around inventory reservations, I was surprised to see that
_*reserveProductInventory*_ service only checks for QOH quantity greater than one apart from
that when _*reserveFromInventoryItemInline*_ is called, it checks for ATP confirming system
to behave as required.
> Everything works fine but this is redundant code and we can have check for ATP at top
level so make reservations logic works faster. We can improve this flow by adding ATP check
at _*reserveProductInventory*_ service as well.
> We can check QOH being on safer side, but ideally a system will always have lesser ATP
than QOH and logically we should only check for ATP while doing reservations.
> Same discussion is also available on dev ML.

This message was sent by Atlassian JIRA

View raw message