ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deepak Dixit (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10331) Improve Order
Date Mon, 09 Apr 2018 12:22:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430440#comment-16430440
] 

Deepak Dixit commented on OFBIZ-10331:
--------------------------------------

Hi  Dennis Balkir ,

I reviewed OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, in this patch you used
form inside table and its semantically incorrect markup, and form is not a valid child of
table,

To fix UX pattern we can't use semantically incorrect markup.

> Improve Order
> -------------
>
>                 Key: OFBIZ-10331
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10331
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Priority: Minor
>         Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, OFBIZ-10221_common-theme.template.includes.GenericLink.patch,
OFBIZ-10221_order.template.entry.CheckInits.patch, OFBIZ-10221_order.template.entry.ChooseCatalog.patch,
OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, OFBIZ-10221_order.template.entry.OrderAgreements.patch,
OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, OFBIZ-10221_order.template.entry.OrderShortcuts.patch,
OFBIZ-10221_order.template.entry.cart.ShowCart.patch, OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch,
OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, OFBIZ-10221_order.template.order.FindOrders.patch,
OFBIZ-10221_order.template.order.OrderList.patch, OFBIZ-10221_order.template.order.OrderStats.patch,
OFBiz-10221_order.template.order.OrderContactInfo.patch, OFBiz-10221_order.template.order.OrderInfo.patch,
OFBiz-10221_order.template.order.OrderItems.patch, OFBiz-10221_order.template.order.OrderPaymentInfo.patch,
OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message