From notifications-return-17380-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Tue Mar 27 09:48:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D480718064E for ; Tue, 27 Mar 2018 09:48:04 +0200 (CEST) Received: (qmail 13052 invoked by uid 500); 27 Mar 2018 07:48:03 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 13043 invoked by uid 99); 27 Mar 2018 07:48:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2018 07:48:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 03166180156 for ; Tue, 27 Mar 2018 07:48:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MIi6py3MkW7Y for ; Tue, 27 Mar 2018 07:48:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3F9635F4EB for ; Tue, 27 Mar 2018 07:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6F93FE0D8F for ; Tue, 27 Mar 2018 07:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2422621503 for ; Tue, 27 Mar 2018 07:48:00 +0000 (UTC) Date: Tue, 27 Mar 2018 07:48:00 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411153#comment-16411153 ] Jacques Le Roux edited comment on OFBIZ-10304 at 3/27/18 7:47 AM: ------------------------------------------------------------------ I reopen this issue after this discussion on dev ML: [https://markmail.org/message/yjlpzrwy7ptnvll6] I think we need to revisit OFBIZ-10047 because I found another occurence of the problem in payPalCheckoutUpdate. Jacopo said he will review the Tomcat SSO code and I'll try too. *Actually note that the Tomcat SSO code only made appears this issue, it's not the "'culprit" Tomcat 8.5 with its servlet4preview is .* was (Author: jacques.le.roux): I reopen this issue after this discussion on dev ML: https://markmail.org/message/yjlpzrwy7ptnvll6 I think we need to revisit OFBIZ-10047 because I found another occurence of the problem in payPalCheckoutUpdate. Jacopo said he will review the Tomcat SSO code and I'll try too. > The "request" attribute type of the userLogin service is wrong > -------------------------------------------------------------- > > Key: OFBIZ-10304 > URL: https://issues.apache.org/jira/browse/OFBIZ-10304 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: Trunk, 17.12.01 > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10304.patch > > > I commited [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679] which I guess forced (or allowed?) James Yong to use the javax.servlet.http.HttpServletRequest as type of "request" attribute of the userLogin service at [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133] > Else it would (should?) have been > > Now I need to revert/remove the wrapper in ContextFilter which is useless and silly (my bad). > {color:#ff0000}-After a deeper investigation today (saturday 2019-03-24) the right solution is now attached as a patch- > UPDATE: we had a discussion on this subject at [https://markmail.org/message/4jwrnbhpapb4ncrd] and Scott suggested to rather temporary use the child element of the element. Temporary because the definitive solution (w/o using ) could be either to update to Tomcat 9 (preferred) or even downgrade to Tomcat 8. I guess nobody really want the later because only the trunk and not yet released R17.12 branch are concerned.{color} -- This message was sent by Atlassian JIRA (v7.6.3#76005)