From notifications-return-16956-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Mon Mar 12 12:45:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D2D5E18067B for ; Mon, 12 Mar 2018 12:45:04 +0100 (CET) Received: (qmail 74647 invoked by uid 500); 12 Mar 2018 11:45:04 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 74638 invoked by uid 99); 12 Mar 2018 11:45:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2018 11:45:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 839B8C1E55 for ; Mon, 12 Mar 2018 11:45:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.51 X-Spam-Level: X-Spam-Status: No, score=-109.51 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100, WEIRD_PORT=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XvKfkG3nlP9H for ; Mon, 12 Mar 2018 11:45:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6D08F5F2EC for ; Mon, 12 Mar 2018 11:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9178AE00E5 for ; Mon, 12 Mar 2018 11:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2D8942146B for ; Mon, 12 Mar 2018 11:45:00 +0000 (UTC) Date: Mon, 12 Mar 2018 11:45:00 +0000 (UTC) From: "Garima jain (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OFBIZ-9240) Ecommerce login/logout don't work properly for trunk and stable and even old MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-9240?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1639= 5083#comment-16395083 ]=20 Garima jain edited comment on OFBIZ-9240 at 3/12/18 11:44 AM: -------------------------------------------------------------- Hii [~jacques.le.roux] I spent some time around it and found that 1. If the user is currently logged in and requests for login again from URL= then, instead of redirecting it to 'main' screen, it redirects to the logi= n screen and displays the error message. Actual: If the user is currently logged in and requests for login again fro= m URL, then the user should redirect to the 'main' screen. This issue also exists in e-commerce and backend. To fix it: We can check the value of 'isUserLoggedIn()' in LoginWorker.java= file. If 'isUserLoggedIn()' returns true, we can return a string "userLogg= edIn" which we can check in the controller to redirect it to the main scree= n. for reference: screenshots attached.=C2=A0 !ecomseo.png! was (Author: garima.jain): Hii [~jacques.le.roux] I spent some time around it and found that 1. If the user is currently logged in and requests for login again from URL= then, instead of redirecting it to 'main' screen, it redirects to the logi= n screen and displays the error message. Actual: If the user is currently logged in and requests for login again fro= m URL, then the user should redirect to the 'main' screen. This issue also exists in e-commerce and backend. To fix it: We can check the value of 'isUserLoggedIn()' in LoginWorker.java= file. If 'isUserLoggedIn()' returns true, we can return a string "userLogg= edIn" which we can check in the controller to redirect it to the main scree= n. for reference: screenshots attached.=C2=A0 !backend.png! > Ecommerce login/logout don't work properly for trunk and stable and even = old > -------------------------------------------------------------------------= --- > > Key: OFBIZ-9240 > URL: https://issues.apache.org/jira/browse/OFBIZ-9240 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, R= elease Branch 16.11 > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Major > Fix For: 16.11.04 > > Attachments: OFBIZ-9240.patch, backend.png, ecomseo.png > > > Here are the tests I did and their results. I did not consider R14/15 be= cause of OFBIZ-9235 > h5. On demos before fixing OFBIZ-9206 and using ofbiz-vm2 direct access > h6. ecomseo trunk and stable (R16) > # Get to https://demo-trunk.ofbiz.apache.org/ecomseo/ or https://demo-sta= ble.ofbiz.apache.org/ecomseo/ > # login =3D> main page logged in > # logout =3D> main page, not logged in > # login =3D> main page logged in > # Use the "Not you" link =3D> 404 > # Refresh (F5 key) get you to the main page, not logged in > So it works almost correctly but you need a refresh (F5 key) for the "Not= you" link, not sure why yet. > It"s the same locally with OFBIZ-9206 fixed*, w/ or w/o portoffset > h6. ecommerce trunk and stable (R16) > # Get to https://ofbiz-vm2.apache.org:8443/ecommerce or https://ofbiz-vm2= .apache.org:18443/ecommerce > # login =3D> blank page (no 404 in access log) > # Refresh (F5 key) get you to the main page, logged in > # logout =3D> blank page (no 404 in access log) > # Refresh (F5 key) get you to the main page, not logged in > # login =3D> blank page (no 404 in access log) > # Refresh (F5 key) get you to the main page, logged in > # use the "Not you" link =3D> blank page (no 404 in access log) > # Refresh (F5 key) get you to the main page, not logged in > So it works almost correctly but you need a refresh (F5 key) between in t= he 3 cases, not sure why yet. > It's the same locally *with OFBIZ-9206 fixed*, w/ or w/o portoffset > h6. Old (R13) on demo (no ecomseo before R14) > # Get to https://ofbiz-vm2.apache.org:28443/ecommerce > # login =3D> you need to enter it twice =3D> main page logged in > # logout =3D> main page, not logged in > # login =3D> main page logged in > # use the "Not you" link =3D> main page, not logged in > So it "works" but initially you need to enter the credential twice to log= in > It's the same locally *with OFBIZ-9206 "fixed" (I'm not yet sure about th= at, I need to test on demo)*, w/ or w/o portoffset -- This message was sent by Atlassian JIRA (v7.6.3#76005)