ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong
Date Tue, 27 Mar 2018 07:24:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jacques Le Roux updated OFBIZ-10304:
------------------------------------
    Description: 
I commited [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
which I guess forced (or allowed?) James Yong to use the javax.servlet.http.HttpServletRequest
as type of "request" attribute of the userLogin service at [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]

Else it would (should?) have been
 <attribute name="request" mode="IN" type="org.apache.catalina.connector.RequestFacade"
optional="true"/>

Now I need to revert/remove the wrapper in ContextFilter which is useless and silly (my bad).

 

{color:#FF0000}After a deeper investigation today (saturday 2019-03-24) the right solution
is now attached as a patch{color}
Update: we had a discussion on this subject at 

  was:
I commited [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
which I guess forced (or allowed?) James Yong to use the javax.servlet.http.HttpServletRequest
as type of "request" attribute of the userLogin service at [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]

Else it would (should?) have been
 <attribute name="request" mode="IN" type="org.apache.catalina.connector.RequestFacade"
optional="true"/>

Now I need to revert/remove the wrapper in ContextFilter which is useless and silly (my bad).

 

{color:#FF0000}After a deeper investigation today (saturday 2019-03-24) the right solution
is now attached as a patch{color}


> The "request" attribute type of the userLogin service is wrong
> --------------------------------------------------------------
>
>                 Key: OFBIZ-10304
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10304
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-10304.patch
>
>
> I commited [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
which I guess forced (or allowed?) James Yong to use the javax.servlet.http.HttpServletRequest
as type of "request" attribute of the userLogin service at [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]
> Else it would (should?) have been
>  <attribute name="request" mode="IN" type="org.apache.catalina.connector.RequestFacade"
optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and silly (my
bad).
>  
> {color:#FF0000}After a deeper investigation today (saturday 2019-03-24) the right solution
is now attached as a patch{color}
> Update: we had a discussion on this subject at 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message