ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10141) Add a VERSION file in root dir
Date Tue, 20 Feb 2018 16:15:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370210#comment-16370210
] 

Michael Brohl commented on OFBIZ-10141:
---------------------------------------

I've added a simpler solution as a patch. It just shows the usage in the rainbowstone theme,
I'll complete it when it gets accepted by the community.

The solution works with just a VERSION file and a small addition to every footer file in the
templates. No build.gradle enhancements or additional ftl files needed.

> Add a VERSION file in root dir
> ------------------------------
>
>                 Key: OFBIZ-10141
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10141
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Blocker
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-10141.patch, OFBIZ-10141_Add_VERSION_file_simpler_solution.patch
>
>
> Following discussion at http://markmail.org/message/ut74mzptruubw4ty we have decided
to
> # have VERSION file at project root to store released version.
> # Render the version in the applications footer template as a HTML comment.
> Also [~mbrohl] suggested that 
> #  it can be automatically set by (custom) builds to be generated.
> #  It should be made configurable in general.properties to prevent to show it if the
user does not want this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message