From notifications-return-15704-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Fri Jan 5 08:11:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id D8893180647 for ; Fri, 5 Jan 2018 08:11:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C82A2160C27; Fri, 5 Jan 2018 07:11:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 19CA8160C19 for ; Fri, 5 Jan 2018 08:11:03 +0100 (CET) Received: (qmail 61719 invoked by uid 500); 5 Jan 2018 07:11:03 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 61710 invoked by uid 99); 5 Jan 2018 07:11:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2018 07:11:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C4BCFC0AD5 for ; Fri, 5 Jan 2018 07:11:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ZBJwpSIcOhHu for ; Fri, 5 Jan 2018 07:11:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6C0175F286 for ; Fri, 5 Jan 2018 07:11:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 90D72E0C25 for ; Fri, 5 Jan 2018 07:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4A1DA240E2 for ; Fri, 5 Jan 2018 07:11:00 +0000 (UTC) Date: Fri, 5 Jan 2018 07:11:00 +0000 (UTC) From: "Deepak Dixit (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-10143) Hardcoded String in PaymentGatewayServices#processCaptureResult MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312589#comment-16312589 ] Deepak Dixit commented on OFBIZ-10143: -------------------------------------- Thanks Kyra Pritzel-Hentley for your contribution. Your patch has been committed at ofbiz framework trunk at r#1820262 ofbiz framework 17.12 at r#1820263 > Hardcoded String in PaymentGatewayServices#processCaptureResult > --------------------------------------------------------------- > > Key: OFBIZ-10143 > URL: https://issues.apache.org/jira/browse/OFBIZ-10143 > Project: OFBiz > Issue Type: Bug > Components: accounting > Affects Versions: Trunk > Reporter: Kyra Pritzel-Hentley > Assignee: Deepak Dixit > Priority: Trivial > Fix For: 17.12.01 > > Attachments: OFBIZ-10143_processCaptureResult_String.patch, OFBIZ-10143_processCaptureResult_String.patch > > > {code:java} > // otherwise default to Company and print a big warning about this > partyIdTo = "Company"; > Debug.logWarning("Using default value of [" + partyIdTo + "] for payTo on invoice [" + invoiceId + "] and orderPaymentPreference [" > + paymentPreference.getString("orderPaymentPreferenceId") + "]", module); > {code} > partyIdTo default value should be final String. -- This message was sent by Atlassian JIRA (v6.4.14#64029)