From notifications-return-15710-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Fri Jan 5 11:12:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id AA884180647 for ; Fri, 5 Jan 2018 11:12:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9A4D5160C19; Fri, 5 Jan 2018 10:12:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE11A160C27 for ; Fri, 5 Jan 2018 11:12:05 +0100 (CET) Received: (qmail 87071 invoked by uid 500); 5 Jan 2018 10:12:05 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 87061 invoked by uid 99); 5 Jan 2018 10:12:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2018 10:12:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8AD031A04F9 for ; Fri, 5 Jan 2018 10:12:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.011 X-Spam-Level: X-Spam-Status: No, score=-100.011 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PXd1qvra7DmZ for ; Fri, 5 Jan 2018 10:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 78AAA5FBC1 for ; Fri, 5 Jan 2018 10:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E75EBE256E for ; Fri, 5 Jan 2018 10:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 55708240FA for ; Fri, 5 Jan 2018 10:12:00 +0000 (UTC) Date: Fri, 5 Jan 2018 10:12:00 +0000 (UTC) From: "Michael Brohl (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-10133) streaming large content cause out of memory exception. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312850#comment-16312850 ] Michael Brohl commented on OFBIZ-10133: --------------------------------------- Mmmhh, the latest patch contains a lot of formatting changes and other bugfixes, so it's not easy to see the issue related changes. I see some other improvements that can be done , e.g. to check for diamond operators. Maybe better to split the patch into the core changes according to the issue and provide another patch for the formatting/refactoring on base of it and make two commits. Else the patch looks good to me. > streaming large content cause out of memory exception. > ------------------------------------------------------ > > Key: OFBIZ-10133 > URL: https://issues.apache.org/jira/browse/OFBIZ-10133 > Project: OFBiz > Issue Type: Bug > Components: content > Affects Versions: Trunk > Reporter: Wai > Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch > > > When ofbiz streams a large content (eg. video file), get out of memory exception. > console output... > 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase |E| Java heap space > java.lang.OutOfMemoryError: Java heap space > at org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127) ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158) ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) ~[commons-io-2.5.jar:2.5] > -- This message was sent by Atlassian JIRA (v6.4.14#64029)