Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6A49F200D6F for ; Mon, 1 Jan 2018 18:35:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 68E2A160C37; Mon, 1 Jan 2018 17:35:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AD806160C11 for ; Mon, 1 Jan 2018 18:35:11 +0100 (CET) Received: (qmail 1678 invoked by uid 500); 1 Jan 2018 17:35:10 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 1669 invoked by uid 99); 1 Jan 2018 17:35:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jan 2018 17:35:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 74AB81805C8 for ; Mon, 1 Jan 2018 17:35:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_NONE=-0.0001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id tyvl8rUDVBeJ for ; Mon, 1 Jan 2018 17:35:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C0EBB5F3E1 for ; Mon, 1 Jan 2018 17:35:09 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 11DD1E0EEF for ; Mon, 1 Jan 2018 17:35:08 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id ABBF524112 for ; Mon, 1 Jan 2018 17:35:03 +0000 (UTC) Date: Mon, 1 Jan 2018 17:35:03 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-10131) ID should be the abbreviation for identity in English MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 01 Jan 2018 17:35:12 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307511#comment-16307511 ] Jacques Le Roux commented on OFBIZ-10131: ----------------------------------------- This sounds straightforward and good to me. But remember English is not the only language we use. So we need to check that in ModelFormField.java. Seems that German uses the same convention. I don't think we need much more reviews for such trivial changes, but they are always welcome. > ID should be the abbreviation for identity in English > ----------------------------------------------------- > > Key: OFBIZ-10131 > URL: https://issues.apache.org/jira/browse/OFBIZ-10131 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS > Affects Versions: Trunk > Reporter: James Yong > Assignee: James Yong > Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-10131.patch > > > This affects the display on the web pages. Not the naming of variables in the codes. > Will search the *Labels.xml files and replace the word 'Id' with 'ID'. > Will also improve the logic for auto title so that labels generated for variables like productTypeId will be 'Product Type ID' instead of 'Product Type Id'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)