From notifications-return-16005-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Tue Jan 16 14:48:12 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 387B218066D for ; Tue, 16 Jan 2018 14:48:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 250CA160C34; Tue, 16 Jan 2018 13:48:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6B7C1160C26 for ; Tue, 16 Jan 2018 14:48:11 +0100 (CET) Received: (qmail 74843 invoked by uid 500); 16 Jan 2018 13:48:10 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 74834 invoked by uid 99); 16 Jan 2018 13:48:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 13:48:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1265BCC235 for ; Tue, 16 Jan 2018 13:48:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id jD7JcQ-XsFAX for ; Tue, 16 Jan 2018 13:48:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2387B5F23C for ; Tue, 16 Jan 2018 13:48:09 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 635F2E25B6 for ; Tue, 16 Jan 2018 13:48:07 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 39EA221307 for ; Tue, 16 Jan 2018 13:48:05 +0000 (UTC) Date: Tue, 16 Jan 2018 13:48:05 +0000 (UTC) From: "Dennis Balkir (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-10031?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163= 27122#comment-16327122 ]=20 Dennis Balkir edited comment on OFBIZ-10031 at 1/16/18 1:47 PM: ---------------------------------------------------------------- * didn=E2=80=99t convert the unnecessary services, as seen in this issue: h= ttps://issues.apache.org/jira/browse/OFBIZ-10146, maybe someone can have a = look at that too * Line 465: this seems like it was planned to be changed, maybe this is th= e right time to do that, since we=E2=80=99re already doing changes to this = Service * Couldn=E2=80=99t fully delete CatalogServices.xml, since one of its simp= le-methods (checkCategoryRelatedPermission) is used in another method in an= other .xml-file (/applications/commonext/minilang/setup/SetupEvents.xml). U= nfortunately there is no service which defines this method, which means, th= at I cannot use a service instead. * I tested all the services in this file as good as I could, they seem to = work and do what they should do I would appreciate if one of the involved people can give me a feedback on = this file, thanks :) was (Author: dennis balkir): * didn=E2=80=99t convert the unnecessary services, as seen in this issue, m= aybe someone can have a look at that too * Line 465: this seems like it was planned to be changed, maybe this is th= e right time to do that, since we=E2=80=99re already doing changes to this = Service * Couldn=E2=80=99t fully delete CatalogServices.xml, since one of its simp= le-methods (checkCategoryRelatedPermission) is used in another method in an= other .xml-file (/applications/commonext/minilang/setup/SetupEvents.xml). U= nfortunately there is no service which defines this method, which means, th= at I cannot use a service instead. * I tested all the services in this file as good as I could, they seem to = work and do what they should do I would appreciate if one of the involved people can give me a feedback on = this file, thanks :) > Convert CategoryServices.xml mini lang to groovy > ------------------------------------------------ > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework > Affects Versions: Trunk > Reporter: Dennis Balkir > Priority: Minor > Attachments: OFBIZ-10031_org.apache.ofbiz.product.category.Catego= ryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)