From notifications-return-16121-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org Sun Jan 21 11:10:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7A5EF180652 for ; Sun, 21 Jan 2018 11:10:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 69E10160C37; Sun, 21 Jan 2018 10:10:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AF8D7160C32 for ; Sun, 21 Jan 2018 11:10:03 +0100 (CET) Received: (qmail 23089 invoked by uid 500); 21 Jan 2018 10:10:02 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 23080 invoked by uid 99); 21 Jan 2018 10:10:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 21 Jan 2018 10:10:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 57B27C313F for ; Sun, 21 Jan 2018 10:10:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -106.598 X-Spam-Level: X-Spam-Status: No, score=-106.598 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URI_HEX=1.313, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Y7vyv-AM9HWr for ; Sun, 21 Jan 2018 10:10:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C48815FAC8 for ; Sun, 21 Jan 2018 10:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5137AE02C8 for ; Sun, 21 Jan 2018 10:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0F7B120EA9 for ; Sun, 21 Jan 2018 10:10:00 +0000 (UTC) Date: Sun, 21 Jan 2018 10:10:00 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-4931) Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix" MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333441#comment-16333441 ] Jacques Le Roux commented on OFBIZ-4931: ---------------------------------------- What is the situation here? We know it's useful in the standard context but throw a bug in multi-tenant context, so what next? > Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix" > ----------------------------------------------------------------------------- > > Key: OFBIZ-4931 > URL: https://issues.apache.org/jira/browse/OFBIZ-4931 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: Trunk > Reporter: Wai > Priority: Major > Attachments: OFBIZ-4931.patch > > > In reference to the posting, http://ofbiz.135035.n4.nabble.com/Proposal-to-remove-catalog-s-quot-Template-Path-Prefix-quot-field-from-user-interface-td4633296.html > http://demo-trunk.ofbiz.apache.org/catalog/control/EditProdCatalog?prodCatalogId=DemoCatalog > It seems that the code blindly prepends the "Template Path Prefix" value to the category's "Detail Screen" field resulting in a file path format that would cause an exception. > Hence, if a catalog's "Template Path Prefix" is "zzz" and a category's "Detail Screen" is "somedetailscreen", the resulting screen that ofbiz looks for is "/zzzsomedetailscreen". Which ofbiz would not be able to locate based on the format of the screen location. Hence, cause an exception. > If a catalog's "Template Path Prefix" is "zzz" and a category's "Detail Screen" is "component://ecommerce/widget/CatalogScreens.xml#somedetailscreen", the resulting screen that ofbiz looks for is "/zzzcomponent://ecommerce/widget/CatalogScreens.xml#somedetailscreen". Which ofbiz would not be able to located due to the improper format. Hence cause an exception. > Since this code never worked since 2006 when it was first placed into the svn repository. I don't think anyone has made use of it since. > Regarding a catalog's "Content Path Prefix" field, it also exhibits the same flaw. That of blindly prepending this field. This field is generally used to specify the product images to be shown in the ecommerce component. > When this field is empty, the generated image url in ecommerce is shown below (note that it is using "image" webapp context): > /images/products/ENCHILADAS/small.png > If you were to specify "/zzz" for "Content Path Prefix", the resulting url for the generated image tag is shown below (note that it is using "zzz" webapp context): > /zzz/images/products/ENCHILADAS/small.png > As you can see. "Content Path Prefix" specifies a "zzz" webapp context with a subdirectory "image". I doubt this was the intent of the field. The question is, where exactly are you supposed to place this field value? > I propose to remove the catalog's "Template Path Prefix" field from the catalog's user interface and assoc code to reduce the confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)