ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kyra Pritzel-Hentley (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-10143) Hardcoded String in PaymentGatewayServices#processCaptureResult
Date Thu, 04 Jan 2018 13:19:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kyra Pritzel-Hentley updated OFBIZ-10143:
-----------------------------------------
    Attachment: OFBIZ-10143_processCaptureResult_String.patch

Hello Deepak,
thank you very much for the info. I was thinking aboout creating my own property but thought
it was too much of a hasstle just for one String. I will look into the properties first, the
next time I replace hardcoded Strings :)

This patch now contains the call to the property value. Additionally I replaced hardcoded
strings, which represent names of resources, with the appropriate final String. 

So overall code improvements.

> Hardcoded String in PaymentGatewayServices#processCaptureResult
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-10143
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10143
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Kyra Pritzel-Hentley
>            Priority: Trivial
>         Attachments: OFBIZ-10143_processCaptureResult_String.patch, OFBIZ-10143_processCaptureResult_String.patch
>
>
> {code:java}
> // otherwise default to Company and print a big warning about this
> partyIdTo = "Company";
> Debug.logWarning("Using default value of [" + partyIdTo + "] for payTo on invoice ["
+ invoiceId + "] and orderPaymentPreference ["
> + paymentPreference.getString("orderPaymentPreferenceId") + "]", module);
> {code}
> partyIdTo default value should be final String.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message