ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Yong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10131) ID should be the abbreviation for identity in English
Date Wed, 03 Jan 2018 15:11:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309775#comment-16309775
] 

James Yong commented on OFBIZ-10131:
------------------------------------

Hi Jacques,

What you mention is correct. To add on further..

On why I don’t check for English locale before the Id-to-ID substitution:
Assume current locale is Chinese and there is no translation for productTypeId. 
If I don’t check for English locale before substitution, the display will show ‘Product
Type ID’.
if I check for English locale before substitution, the display will show ‘Product Type Id’
 because current locale is Chinese and Id-to-ID substitution didn’t happens.

Only made changes to the labels with ‘en’ locale. Didn’t find any changes required for
‘en_XX’ locale. If other locales require the same change, I think is better done by those
who understand the language.

Regards,
James

> ID should be the abbreviation for identity in English
> -----------------------------------------------------
>
>                 Key: OFBIZ-10131
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10131
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: James Yong
>            Assignee: James Yong
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-10131.patch, OFBIZ-10131.patch
>
>
> This affects the display on the web pages. Not the naming of variables in the codes.
> Will search the *Labels.xml files and replace the word 'Id' with 'ID'.
> Will also improve the logic for auto title so that labels generated for variables like
productTypeId will be 'Product Type ID' instead of 'Product Type Id'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message