ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10131) ID should be the abbreviation for identity in English
Date Mon, 01 Jan 2018 17:35:03 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307511#comment-16307511

Jacques Le Roux commented on OFBIZ-10131:

This sounds straightforward and good to me. 
But remember English is not the only language we use. So we need to check that in ModelFormField.java.
Seems that German uses the same convention.

I don't think we need much more reviews for such trivial changes, but they are always welcome.

> ID should be the abbreviation for identity in English
> -----------------------------------------------------
>                 Key: OFBIZ-10131
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10131
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: James Yong
>            Assignee: James Yong
>            Priority: Minor
>             Fix For: Upcoming Release
>         Attachments: OFBIZ-10131.patch
> This affects the display on the web pages. Not the naming of variables in the codes.
> Will search the *Labels.xml files and replace the word 'Id' with 'ID'.
> Will also improve the logic for auto title so that labels generated for variables like
productTypeId will be 'Product Type ID' instead of 'Product Type Id'.

This message was sent by Atlassian JIRA

View raw message