Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 36E87200D69 for ; Tue, 12 Dec 2017 10:15:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 324CC160BE7; Tue, 12 Dec 2017 09:15:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 77DA4160C0F for ; Tue, 12 Dec 2017 10:15:06 +0100 (CET) Received: (qmail 13652 invoked by uid 500); 12 Dec 2017 09:15:05 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 13638 invoked by uid 99); 12 Dec 2017 09:15:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2017 09:15:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4A63C1807BA for ; Tue, 12 Dec 2017 09:15:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id JJJzCSXdF96h for ; Tue, 12 Dec 2017 09:15:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5340A5F3B7 for ; Tue, 12 Dec 2017 09:15:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 52E5EE0D67 for ; Tue, 12 Dec 2017 09:15:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4F03A212FD for ; Tue, 12 Dec 2017 09:15:01 +0000 (UTC) Date: Tue, 12 Dec 2017 09:15:01 +0000 (UTC) From: "Michael Brohl (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-9870) [Refactoring] Package org.apache.ofbiz.accounting.invoice MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 12 Dec 2017 09:15:07 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287300#comment-16287300 ] Michael Brohl commented on OFBIZ-9870: -------------------------------------- I think we should discuss this. In my view, trailing white spaces are part of the refactoring. They do not belong there and should be removed. You can adjust your IDE/Eclipse to ignore whitepaces in diffs, so you only see the real changes. That works very good. > [Refactoring] Package org.apache.ofbiz.accounting.invoice > --------------------------------------------------------- > > Key: OFBIZ-9870 > URL: https://issues.apache.org/jira/browse/OFBIZ-9870 > Project: OFBiz > Issue Type: Sub-task > Components: accounting > Affects Versions: Trunk > Reporter: Dennis Balkir > Assignee: Michael Brohl > Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-9870_org.apache.ofbiz.accounting.invoice.InvoiceServices_refactoring.patch, OFBIZ-9870_org.apache.ofbiz.accounting.invoice.InvoiceWorker_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)