Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8DFD8200D55 for ; Sat, 9 Dec 2017 19:01:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8C732160C20; Sat, 9 Dec 2017 18:01:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CFAE2160BFE for ; Sat, 9 Dec 2017 19:01:03 +0100 (CET) Received: (qmail 22853 invoked by uid 500); 9 Dec 2017 18:01:03 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 22843 invoked by uid 99); 9 Dec 2017 18:01:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Dec 2017 18:01:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E097A180160 for ; Sat, 9 Dec 2017 18:01:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 19Pk5721wioX for ; Sat, 9 Dec 2017 18:01:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DFC3A5F39E for ; Sat, 9 Dec 2017 18:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 74733E01A8 for ; Sat, 9 Dec 2017 18:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3292F212FE for ; Sat, 9 Dec 2017 18:01:00 +0000 (UTC) Date: Sat, 9 Dec 2017 18:01:00 +0000 (UTC) From: "Michael Brohl (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (OFBIZ-9787) [FB] Package org.apache.ofbiz.product.supplier MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 09 Dec 2017 18:01:04 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9787. -------------------------------- Resolution: Implemented Fix Version/s: Upcoming Release Thanks Julian, your patch is in trunk r1817646. > [FB] Package org.apache.ofbiz.product.supplier > ---------------------------------------------- > > Key: OFBIZ-9787 > URL: https://issues.apache.org/jira/browse/OFBIZ-9787 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: Trunk > Reporter: Julian Leichert > Assignee: Michael Brohl > Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-9787_org.apache.ofbiz.product.supplier_bugfixes.patch > > > SupplierProductServices.java:58, DLS_DEAD_LOCAL_STORE > - DLS: Dead store to results in org.apache.ofbiz.product.supplier.SupplierProductServices.getSuppliersForProduct(DispatchContext, Map) > This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. > Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. > SupplierProductServices.java:130, DLS_DEAD_LOCAL_STORE > - DLS: Dead store to results in org.apache.ofbiz.product.supplier.SupplierProductServices.convertFeaturesForSupplier(DispatchContext, Map) > This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. > Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. -- This message was sent by Atlassian JIRA (v6.4.14#64029)